Skip to content
Snippets Groups Projects
  1. Jun 17, 2016
  2. Jun 14, 2016
  3. Jun 13, 2016
  4. Jun 10, 2016
  5. May 03, 2016
  6. Apr 29, 2016
  7. Apr 28, 2016
  8. Apr 21, 2016
    • Valenza Florian's avatar
      [C++][Python][Major] Replaced the way collisions and visuals are stored in... · f2505698
      Valenza Florian authored
      [C++][Python][Major] Replaced the way collisions and visuals are stored in GeometryModel. Now it is two lists of GeometryObject (one for collisions, one for visuals) aggregating information instead of multiple vectors. Now handle multiple collisions/visuals for one link when parsing urdf file and keep track of the mesh absolute path. Changed binding accordingly.
      f2505698
  9. Apr 13, 2016
  10. Apr 10, 2016
  11. Apr 09, 2016
  12. Apr 08, 2016
  13. Apr 04, 2016
  14. Mar 31, 2016
  15. Mar 30, 2016
  16. Mar 25, 2016
  17. Mar 24, 2016
  18. Mar 22, 2016
  19. Mar 17, 2016
  20. Mar 15, 2016
    • Guilhem Saurel's avatar
      fix python tests · 9e3b335f
      Guilhem Saurel authored
      9e3b335f
    • Guilhem Saurel's avatar
      Python clean, mostly pep8 · 626a16ca
      Guilhem Saurel authored
      https://www.python.org/dev/peps/pep-0008/
      
      A few hints:
          + About Spaces:
              - always after a comma
              - never after [, (, {
              - never before ], ), }
              - always around -, +, *, **, %, ==, >=, <=
              - always around = for an assignation
              - never around = for a default value of an argument
              - never at the end of a line
          + One statement by line:
              - nothing after : unless inside []
              - no ;
          + No useless (), like in a simple if or assert
          + Indentation uses four spaces
          + Blanklines:
              - 2 before class or function declaration
              - 1 before class method declaration
              - never more than 2
          + Line length:
              - We said 79. This is far from beeign respected. Maybe 119 is more reasonable
          + Align:
              - at the begining of a line continuation
              - not multiple spaces before = to align multiple assignements
      
      Of course, in our case, it would be tricky to follow some other rules, like:
          N802 function name should be lowercase
          N803 argument name should be lowercase
          N806 variable in function should be lowercase
      
      Other issues may be addressed:
          F401 '<something>' imported but unused
          F403 'from <some_lib> import *' used; unable to detect undefined names
      
      To check all of this:
          flake8 --ignore=N802,N803,N806 --max-line-length=119 <root_folder>
      
      Other things changed:
          - import order (thanks isort)
          - useless elif changed to if
          - useless else removed
          - usage of ValueError, when an argument does not fit the expected type / size
          - issubclass(x.__class__, X) / x.__class__ == X → isinstance(x, X)
          - isinstance accepts a list or a tuple of classes (eg: isinstance(x, (int, float)))
          - print "" → print
      626a16ca
  21. Mar 11, 2016
  22. Mar 10, 2016
  23. Mar 08, 2016
  24. Mar 06, 2016
  25. Mar 04, 2016
  26. Mar 03, 2016
Loading