- Mar 15, 2016
-
-
Guilhem Saurel authored
-
Guilhem Saurel authored
https://www.python.org/dev/peps/pep-0008/ A few hints: + About Spaces: - always after a comma - never after [, (, { - never before ], ), } - always around -, +, *, **, %, ==, >=, <= - always around = for an assignation - never around = for a default value of an argument - never at the end of a line + One statement by line: - nothing after : unless inside [] - no ; + No useless (), like in a simple if or assert + Indentation uses four spaces + Blanklines: - 2 before class or function declaration - 1 before class method declaration - never more than 2 + Line length: - We said 79. This is far from beeign respected. Maybe 119 is more reasonable + Align: - at the begining of a line continuation - not multiple spaces before = to align multiple assignements Of course, in our case, it would be tricky to follow some other rules, like: N802 function name should be lowercase N803 argument name should be lowercase N806 variable in function should be lowercase Other issues may be addressed: F401 '<something>' imported but unused F403 'from <some_lib> import *' used; unable to detect undefined names To check all of this: flake8 --ignore=N802,N803,N806 --max-line-length=119 <root_folder> Other things changed: - import order (thanks isort) - useless elif changed to if - useless else removed - usage of ValueError, when an argument does not fit the expected type / size - issubclass(x.__class__, X) / x.__class__ == X → isinstance(x, X) - isinstance accepts a list or a tuple of classes (eg: isinstance(x, (int, float))) - print "" → print
-
- Mar 11, 2016
-
-
Justin Carpentier authored
Recreate resource retriever behaviour by specifying the ROS_PACKAGE_PATH as environment variable.
-
Valenza Florian authored
-
- Mar 10, 2016
-
-
Valenza Florian authored
[C++][Geom Parser] put default value to empty vector of string for user hint directories. If user's hints and ROS_PACKAGE_PATH empty, then throw error. The function that parse ROS_PACKAGE_PATH doesn't throw errors anymore
-
Valenza Florian authored
[C++][Geom parser] Removed boolean root_joint_added while parsing. Geom parser modified consequently to look for parent of link in pinocchio model now instead of urdf::tree parent joint.
-
- Mar 08, 2016
-
-
Valenza Florian authored
-
Valenza Florian authored
[C++][Pyhton][Geom parser] ROS_PACKAGE_PATHS directories are now added to the ones specified by user
-
Valenza Florian authored
-
Valenza Florian authored
-
Valenza Florian authored
[Python] Update methods and RobotWrapper to use buildGeom instead of buildModelAndGeom and to use a list of package dirs instead of one meshRootDir.If no package_dirs is given by the user, then it will call the C++ procedure that automatically parse the ROS_PACKAGE_PATH
-
Valenza Florian authored
-
Valenza Florian authored
[Python] Added method to convert a python List of string to a C++ vector of string. Warning: the type checking must be made by user before using this function
-
Valenza Florian authored
-
Valenza Florian authored
[C++][Python][Parser Geom] Parse automatically the ROS_PACKAGE_PATH environment variable if not clue is given by the user to where to search for meshes. Change the meshRootDir argument to a vector of strings (package directories). Updated Python consequently
-
- Mar 07, 2016
- Mar 06, 2016
- Mar 05, 2016
-
-
Justin Carpentier authored
Add ABA algorithm
-
- Mar 04, 2016
-
-
Justin Carpentier authored
Inertia.From{Ellipsoid,Cylinder,Box}
-
jcarpent authored
-
jcarpent authored
-
jcarpent authored
-
Guilhem Saurel authored
-
jcarpent authored
-
jcarpent authored
-
Guilhem Saurel authored
-
- Mar 03, 2016
-
-
Justin Carpentier authored
Rework center of mass algo + Python API
-
jcarpent authored
-
- Mar 02, 2016