Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
C
coal
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Coal
coal
Commits
1414c3c6
Commit
1414c3c6
authored
5 years ago
by
Joseph Mirabel
Browse files
Options
Downloads
Patches
Plain Diff
[Minor] Mark what seems to be a bug in BVH::refitTree_bottomup
parent
b5456ce3
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/BVH/BVH_model.cpp
+12
-0
12 additions, 0 deletions
src/BVH/BVH_model.cpp
with
12 additions
and
0 deletions
src/BVH/BVH_model.cpp
+
12
−
0
View file @
1414c3c6
...
...
@@ -764,8 +764,14 @@ int BVHModel<BV>::refitTree(bool bottomup)
template
<
typename
BV
>
int
BVHModel
<
BV
>::
refitTree_bottomup
()
{
// TODO the recomputation of the BV is done manually, without using
// bv_fitter. The manual BV recomputation seems bugged. Using bv_fitter
// seems to correct the bug.
//bv_fitter->set(vertices, tri_indices, getModelType());
int
res
=
recursiveRefitTree_bottomup
(
0
);
//bv_fitter->clear();
return
res
;
}
...
...
@@ -812,6 +818,9 @@ int BVHModel<BV>::recursiveRefitTree_bottomup(int bv_id)
}
else
{
//TODO use bv_fitter to build BV. See comment in refitTree_bottomup
//unsigned int* cur_primitive_indices = primitive_indices + bvnode->first_primitive;
//bv = bv_fitter->fit(cur_primitive_indices, bvnode->num_primitives);
Vec3f
v
[
3
];
for
(
int
i
=
0
;
i
<
3
;
++
i
)
{
...
...
@@ -834,6 +843,9 @@ int BVHModel<BV>::recursiveRefitTree_bottomup(int bv_id)
recursiveRefitTree_bottomup
(
bvnode
->
leftChild
());
recursiveRefitTree_bottomup
(
bvnode
->
rightChild
());
bvnode
->
bv
=
bvs
[
bvnode
->
leftChild
()].
bv
+
bvs
[
bvnode
->
rightChild
()].
bv
;
//TODO use bv_fitter to build BV. See comment in refitTree_bottomup
//unsigned int* cur_primitive_indices = primitive_indices + bvnode->first_primitive;
//bvnode->bv = bv_fitter->fit(cur_primitive_indices, bvnode->num_primitives);
}
return
BVH_OK
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment